Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.28%. Comparing base (21af134) to head (0d7cc4f).
Report is 52 commits behind head on main.

❗ Current head 0d7cc4f differs from pull request most recent head d1f2c6c

Please upload reports for the commit d1f2c6c to get more accurate results.

@@             Coverage Diff              @@
##               main    #9087      +/-   ##
============================================
- Coverage     15.28%   15.28%   -0.01%     
- Complexity    11535    11538       +3     
============================================
  Files          5425     5424       -1     
  Lines        474138   474334     +196     
  Branches      58984    59493     +509     
============================================
+ Hits          72486    72508      +22     
- Misses       393584   393768     +184     
+ Partials       8068     8058      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JSpon does this also need a change in create-kubernetes-iso.sh script to include the custom script while preparing the ISO?

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9638

I like the idea to setup cks cluster in another way than user-data.
however, as @shwstppr said, there should be some changes with create-kubernetes-iso.sh

can you please also share the setup-kube-system files, for example , to install cilium ? @JSpon
the setup process might be very complicated for end users, to be honest.

@shwstppr, @weizhouapache - sure. I am testing examples of setup-kube-system (and deploy-kube-system) and will update my PR with the changes to the create-kubernetes-binaries-iso.sh and the examples (and a README.md) after testing is complete

I made the update to add examples. I had an issue with the first commit, so fixed it and force pushed with the updates.

I made the update to add examples. I had an issue with the first commit, so fixed it and force pushed with the updates.

thanks @JSpon

it looks like refactoring, almost all codes are copied from the k8s-*.yaml
can you point out the main changes ?

@blueorangutan package

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9716

@weizhouapache, the code in basic/scripts is a direct copy, meant as a starting point. The code in cilium has changes only in control-node. The changes are lines 29-35 and 51-63 in setup-kube-system and 31 and 56-57 in deploy-kube-system.tmpl. I can remove the other directories (control-node-add and node) as well as setup-containerd.tmpl in cilium since they aren't needed.

@blueorangutan test alma9 kvm-alma9

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

[SF] Trillian test result (tid-10329)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 50281 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9087-t10329-kvm-alma9.zip
Smoke tests completed. 131 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

@JSpon , sorry to bother you with the apache bylaws, but all files need a license header, except the very trivial ones.

Sorry about that. Thanks for pointing those out. I have made the updates.

@JSpon
To be frank, I think we need to solve two problems

• lots of code are duplicated.
• lots of parameters are passed to setup-kube-system

I do not have suggestion for now.

I have some simple changes to install cilium by command lines. I will create a draft PR. Maybe we can have more discussions and get a better solution.

I like the idea to run some customized scripts before or after k8s setup.

@weizhouapache, understood. I can also come up with a shell script to extract the information from the existing yml files instead of including copies, and figure a way of easily add cilium into that. This would remove the 18 sample files with all of the duplication in favor of the script, if it is worth it.